Make tests pass in western hemisphere#15387
Merged
Conversation
To check support for negative timezones
pmoleri
changed the title
pmoleri
commented
Feb 20, 2025
...ects/igniteui-angular/src/lib/directives/date-time-editor/date-time-editor.directive.spec.ts
Show resolved
Hide resolved
pmoleri
commented
Feb 20, 2025
kdinev
previously approved these changes
Feb 21, 2025
kdinev
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests run to be able to run in US ET timezone without errors.
First commit sets tests to run in America/New_York time zone.
See results: https://github.com/IgniteUI/igniteui-angular/actions/runs/13441426761
Note:
TZenv var trick doesn't seem to work on Windows. Change PC timezone instead.Second commit fixes the tests by making sure that all dates are in local timezone.
e.g.
new Date('2025-01-01')->2024-12-31 19:00 GMT -05:00❌ produces invalid resultsymd('2025-01-01')->2025-01-01 19:00 GMT -05:00✔See also Angular's explanation here, which is what they use for their Date pipe.
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)